CI: enable the SQLA2 special test for airflow-core#52648
CI: enable the SQLA2 special test for airflow-core#52648Dev-iL wants to merge 1 commit intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI workflows for airflow-core by enabling a special test for SQLAlchemy 2, which is part of the overall effort to separate FAB core dependencies from FAB and align with FAB5 transitions.
- Adds a new "tests-latest-sqlalchemy" job to run SQLAlchemy tests in the core workflow.
- Introduces a new workflow input "upgrade-sqlalchemy" to control the SQLAlchemy upgrade behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/special-tests.yml | Adds the new SQLAlchemy test job, configuring testing parameters for core. |
| .github/workflows/run-unit-tests.yml | Adds the "upgrade-sqlalchemy" input and passes it through to the test jobs. |
Dev-iL
force-pushed
the
Dev-iL/2507/enable_sqla2_core_ci
branch
from
12b088e to
e6912d8
Compare
|
Closing since this approach doesn't work unfortunately. |
|
@potiuk Is there any simple way, e.g. via the combination of flags that exclude various tests, to make this workflow succeed? |
We could add an exception to that - but that would require some manual removal of packages and upgrade packages in This will be way easier after we merge #46891 as there we already have Py3.13 completely without fab and all the FAB-dependent tests are either moved out of core (when they were left) or modified to be skipped if fab is not installed - and I think we shoudl be able to merge it in a day or two - so if yoy can wait with that - that would be best. |
|
OK. Merged now. I will take a look at creating the sqla2 job. |
2 participants
Yet another part of #52233. Since airflow-core shouldn't depend on FAB, it might be possible to enable the associated CI workflow (🤞), and only introduce the equivalent workflow for providers after transitioning to FAB5.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.